Implement integrity in import map#2229
Merged
guybedford merged 5 commits intomasterfrom Aug 10, 2020
Merged
Conversation
coreFile by file impact
extrasFile by file impactPull request have no impact on |
internettrans
approved these changes
Aug 10, 2020
Collaborator
internettrans
left a comment
internettrans
left a comment
There was a problem hiding this comment.
Thanks for the explanations. Looks good to me.
Member
Author
|
Released in 6.5.0. |
1 task
This was referenced Jun 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a new
"integrity"attribute in the import map, which is consulted when creating scripts for injection to use as the primary integrity mechanism.In this way a full integrity content security policy can be applied to apps built on top of SystemJS.
Like depcache this is non-standard right now, but I have put together a rough standard outline in the import maps extensions repo at https://github.com/guybedford/import-maps-extensions#integrity.