Skip to content

shell-completion: replace "gdb" verb with "debug" for coredumpctl#9876

Merged
keszybz merged 1 commit intosystemd:masterfrom
jnpkrn:shell-completion-coredumpctl-debug
Aug 20, 2018
Merged

shell-completion: replace "gdb" verb with "debug" for coredumpctl#9876
keszybz merged 1 commit intosystemd:masterfrom
jnpkrn:shell-completion-coredumpctl-debug

Conversation

@jnpkrn
Copy link
Contributor

@jnpkrn jnpkrn commented Aug 16, 2018

Also offer --debugger option. Both to reflect changes in v239.

Also offer --debugger option.  Both to reflect changes in v239.
@jnpkrn jnpkrn force-pushed the shell-completion-coredumpctl-debug branch from 2bf68ff to 15b09bf Compare August 16, 2018 16:34
@jnpkrn jnpkrn changed the title shell_completion: replace "gdb" verb with "debug" for coredumpctl shell-completion: replace "gdb" verb with "debug" for coredumpctl Aug 16, 2018
@filbranden
Copy link
Member

Actually, coredumpctl gdb is still valid, even though it's not listed in the --help text for coredumpctl anymore... Maybe it should still be allowed as a valid completion, not dropped altogether just yet?

Otherwise, looks great, thanks!

@jnpkrn
Copy link
Contributor Author

jnpkrn commented Aug 16, 2018

I am aware it is still valid [1], but isn't it the point of both man pages and
shell completions to drive people to what's intended to be customary
at that very snapshot of the overall evolution?

And man page already does that...

[1] I was actually asking for having the debugger configurable: #9311

@keszybz
Copy link
Member

keszybz commented Aug 20, 2018

The general policy is that we document/auto-complete/show-in---help the same set of non-deprecated options, so this patch follows policy. Let's just merge it, since gdb is so short that anyone is unlikely to use tab-completion on it anyway.

'info:Show detailed information about one or more coredumps'
'dump:Print coredump to stdout'
'gdb:Start gdb on a coredump'
'debug:Start debugger (gdb) on a coredump'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical nitpick: this should be "a debugger" ("gdb" is a name, so no article, but "debugger" is a generic noun, so it needs one).

@keszybz keszybz merged commit 53956fa into systemd:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants