core: when applying io/blkio per-device rules, don't remove them if t…#9275
Merged
poettering merged 1 commit intosystemd:masterfrom Jun 12, 2018
Merged
Conversation
…hey fail These devices might show up later, hence leave the rules as they are. Applying the limits should not alter configuration.
Contributor
|
LGTM FWIW. |
Member
Author
|
thanks for the review! |
poettering
added
the
good-to-merge/waiting-for-ci 👍
Member
|
Yeah, that old code is quite surprising. Patch looks good. |
keszybz
removed
the
good-to-merge/waiting-for-ci 👍
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hey fail
These devices might show up later, hence leave the rules as they are.
Applying the limits should not alter configuration.