Skip to content

core: add MemoryMin#9244

Merged
keszybz merged 1 commit intosystemd:masterfrom
htejun:memory_min
Jul 12, 2018
Merged

core: add MemoryMin#9244
keszybz merged 1 commit intosystemd:masterfrom
htejun:memory_min

Conversation

@htejun
Copy link
Contributor

@htejun htejun commented Jun 9, 2018

The kernel added support for a new cgroup memory controller knob memory.min in
bf8d5d52ffe8 ("memcg: introduce memory.min") which was merged during v4.18
merge window.

Add MemoryLow to support memory.min.

@htejun htejun changed the title core: add MemoryLow core: add MemoryMin Jun 9, 2018
Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@keszybz
Copy link
Member

keszybz commented Jun 9, 2018

semaphoreci failure was unrelated (apt-get trouble), I restarted the build.

bionic-s390x is also unrelated: boot-and-services FAIL stderr: Failed to dump process list for '[email protected]', ignoring: Unit [email protected] not loaded.


<listitem>
<para>Specify the memory usage protection of the executed processes in this unit. If the memory usages of
this unit and all its ancestors are below their min boundaries, this unit's memory won't be reclaimed.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe not abbreviate "minimum" here as "min"?

@poettering
Copy link
Member

this looks good to me, but let's wait until v239 is out before we merge this.

@poettering poettering added this to the v240 milestone Jun 14, 2018
@poettering
Copy link
Member

@htejun 239 has been released now. Any chance you can fix the "min" issue mentioned, in the docs. Looks good to merge then!

facebook-github-bot pushed a commit to facebookarchive/rpm-backports that referenced this pull request Jun 26, 2018
Summary:
New upstream release, plus backports of
systemd/systemd#9244
systemd/systemd#9247 and
systemd/systemd#9410

Reviewed By: jaymzh

Differential Revision: D8609874

fbshipit-source-id: a620516cb7bc4305b144c811aa5eac5d19dc8274
The kernel added support for a new cgroup memory controller knob memory.min in
bf8d5d52ffe8 ("memcg: introduce memory.min") which was merged during v4.18
merge window.

Add MemoryMin to support memory.min.
@htejun
Copy link
Contributor Author

htejun commented Jul 11, 2018

Anything else needed to get this merged?

@keszybz keszybz merged commit 4842263 into systemd:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants