core: use id unit when retrieving unit file state #8038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code was using the basename(id->fragment_path) which returned incorrect result if the unit was an instance. For example, assuming that no instances of "template" have been created so far: $ systemctl enable template@1 Created symlink from /etc/systemd/system/multi-user.target.wants/[email protected] to /usr/lib/systemd/system/[email protected]. $ systemctl is-enabled [email protected] disabled $ systemctl status [email protected] ● [email protected] - openQA Worker systemd#3 Loaded: loaded (/usr/lib/systemd/system/[email protected]; enabled; vendor preset: disabled) [...] Here the unit file states reported by "status" and "is-enabled" were different.
Werkov
pushed a commit
to Werkov/systemd
that referenced
this pull request
Mar 9, 2018
Previous code was using the basename(id->fragment_path) which returned incorrect result if the unit was an instance. For example, assuming that no instances of "template" have been created so far: $ systemctl enable template@1 Created symlink from /etc/systemd/system/multi-user.target.wants/[email protected] to /usr/lib/systemd/system/[email protected]. $ systemctl is-enabled [email protected] disabled $ systemctl status [email protected] ● [email protected] - openQA Worker systemd#3 Loaded: loaded (/usr/lib/systemd/system/[email protected]; enabled; vendor preset: disabled) [...] Here the unit file states reported by "status" and "is-enabled" were different. (cherry picked from commit 9ea3a0e) [fbui: fixes bsc#1075801]
SergioAtSUSE
pushed a commit
to SergioAtSUSE/systemd_systemd
that referenced
this pull request
Jun 7, 2018
Previous code was using the basename(id->fragment_path) which returned incorrect result if the unit was an instance. For example, assuming that no instances of "template" have been created so far: $ systemctl enable template@1 Created symlink from /etc/systemd/system/multi-user.target.wants/[email protected] to /usr/lib/systemd/system/[email protected]. $ systemctl is-enabled [email protected] disabled $ systemctl status [email protected] ● [email protected] - openQA Worker systemd#3 Loaded: loaded (/usr/lib/systemd/system/[email protected]; enabled; vendor preset: disabled) [...] Here the unit file states reported by "status" and "is-enabled" were different. (cherry picked from commit 9ea3a0e) [fbui: fixes bsc#1075801]
Werkov
pushed a commit
to Werkov/systemd
that referenced
this pull request
Nov 27, 2018
Previous code was using the basename(id->fragment_path) which returned incorrect result if the unit was an instance. For example, assuming that no instances of "template" have been created so far: $ systemctl enable template@1 Created symlink from /etc/systemd/system/multi-user.target.wants/[email protected] to /usr/lib/systemd/system/[email protected]. $ systemctl is-enabled [email protected] disabled $ systemctl status [email protected] ● [email protected] - openQA Worker systemd#3 Loaded: loaded (/usr/lib/systemd/system/[email protected]; enabled; vendor preset: disabled) [...] Here the unit file states reported by "status" and "is-enabled" were different. (cherry picked from commit 9ea3a0e) [fbui: fixes bsc#1075801]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code was using the basename(id->fragment_path) which returned
incorrect result if the unit was an instance.
For example, assuming that no instances of "template" have been created so far:
$ systemctl enable template@1
Created symlink from /etc/systemd/system/multi-user.target.wants/[email protected] to /usr/lib/systemd/system/[email protected].
$ systemctl is-enabled [email protected]
disabled
$ systemctl status [email protected]
● [email protected] - openQA Worker #3
Loaded: loaded (/usr/lib/systemd/system/[email protected]; enabled; vendor preset: disabled)
[...]
Here the unit file states reported by "status" and "is-enabled" were different.