Skip to content

build-sys: require libmount >= 2.30#6795

Merged
keszybz merged 1 commit intosystemd:masterfrom
keszybz:bump-libmount-version
Sep 15, 2017
Merged

build-sys: require libmount >= 2.30#6795
keszybz merged 1 commit intosystemd:masterfrom
keszybz:bump-libmount-version

Conversation

@keszybz
Copy link
Member

@keszybz keszybz commented Sep 11, 2017

Fixes #4871.

The new libmount has two changes relevant for us:

libmount-2.30 has been out for a while now, Fedora 26 and later are at 2.30.1.

@poettering
Copy link
Member

poettering commented Sep 11, 2017

the relevant line in README needs some updating for this too.

Both CIs failure currently. @martinpitt any chance you can pull in newer libmount into your repositories for make our CIs work again?

@keszybz
build-sys: require libmount >= 2.30
8e13c38 
Fixes systemd#4871.

The new libmount has two changes relevant for us:

- x-* options are propagated to /run/mount/utab and are visible through
  libmount (fixes systemd#4817).

- umount -c now really works (partially solves systemd#6115).
@keszybz
Copy link
Member Author

keszybz commented Sep 11, 2017

I tried to add artful to the repository list, but that results in various warnings from apt (I guess the versions are too far apart), and then apt update hangs. I backed that out now.

It seems that the best solution would be for @martinpitt to update his PPA to also inlcude libmount-2.30.1. Let's wait with this PR until then.

@keszybz keszybz force-pushed the bump-libmount-version branch from 3b67dd1 to 8e13c38 Compare September 11, 2017 20:43
This was referenced Sep 12, 2017
Closed
Closed
@martinpitt
Copy link
Contributor

martinpitt commented Sep 15, 2017

I uploaded a backport of util-linux 2.30.1 to the CI PPA for Ubuntu 16.04, which was fairly simple. That will take care of the autopkgtests, I retried them now.

For semaphore we need a backport to Ubuntu 14.04 (ugh, there are still no less ancient images available there, not on trello either ☹), I look into that.

@keszybz
Copy link
Member Author

keszybz commented Sep 15, 2017

Maybe we should just revert the patch on semaphore? (More precisely, just do some sed -i invocation to drop the version requirement completely). We won't be testing hanging nfs mounts on semaphore, so we don't really need that specific version.

@martinpitt
Copy link
Contributor

martinpitt commented Sep 15, 2017

@keszybz , nah, it's okay. I just finished and uploaded the backport. It's not very clean (pg and tailf don't build, presumably due to too old ncurses or whatnot, so I just dropped them - not important for our purposes), but the libmount part should be okay.

@martinpitt
Copy link
Contributor

martinpitt commented Sep 15, 2017

Oops, the backport has a Breaks: which wreaks havoc on xenial, need to fix that.

@keszybz keszybz removed the postponed label Sep 15, 2017
@keszybz keszybz added this to the v235 milestone Sep 15, 2017
@poettering poettering added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Sep 15, 2017
@keszybz keszybz removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Sep 15, 2017
@keszybz keszybz merged commit d6e8096 into systemd:master Sep 15, 2017
jhershbe added a commit to jhershbe/systemd that referenced this pull request Oct 1, 2018
@jhershbe
Revert "build-sys: require libmount >= 2.30 (systemd#6795)"
a10e95b 
This reverts commit d6e8096.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build-system

Milestone

v235

Development

Successfully merging this pull request may close these issues.

Reminder: bump libmount dependency to 2.30 Testing for x-initrd.mount in should_umount() broken?

3 participants

@keszybz @poettering @martinpitt