Revert "build-sys: hide magic section variables from exported symbols"#653
Revert "build-sys: hide magic section variables from exported symbols"#653keszybz merged 1 commit intosystemd:masterfrom
Conversation
This reverts commit aac7c5e. This visibility bug originated in ld.gold and has been fixed upstream: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5417c94d1a944d1a27f99240e5d62a6d7cd324f1
|
Would it be possible to keep the patch until a binutils release with the fix is available? |
|
We should probably wait for the binutils release. Also, an addition to README or NEWS regarding the minimum binutils versions would be good. |
|
Hmm @dvdhrm any idea if binutils did get a realease out with this yet? |
|
Nope, still waiting for 2.26. |
|
I guess we can merge it now. |
|
Is the work around causing any trouble? I'd rather wait a bit to let people get the updated binutils using normal distribution channels. |
|
I'll ping our binutils maintainer to update to 2.60 in unstable and report back once it is updated. |
|
Seems our binutils maintainer was quick. It was already updated a few hours ago: So no objections from the Debian POV. |
|
So, everyone is fine with merging this? I just re-triggered the CI on this ancient branch, and it is still happy. |
|
Why hurry? At least Fedora 23 doesn't have binutils 2.26. |
|
It's been a while, and I guess this should be ok to land now, or dropped if we don't care enough about the workaround. If we still want it, @dvdhrm can you please rebase to current master, so that we get a CI run with the current code? |
|
Dropping "postponed" tag, this needs rebasing instead if we want to apply this now (which seems totally reasonable), or otherwise closed. |
|
No rebase needed. Seems to work fine on F24. |
6 participants
This reverts commit aac7c5e. This
visibility bug originated in ld.gold and has been fixed upstream:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5417c94d1a944d1a27f99240e5d62a6d7cd324f1
There is no binutils release with this fix, yet. So input is welcome whether we should continue carrying this fix or leave it up to distros (@kaysievers, @poettering, @keszybz).