log: pass the correct length to vsnprintf#6168
Merged
keszybz merged 1 commit intosystemd:masterfrom Jun 22, 2017
Merged
Conversation
This prevents log_object_internalv from corrupting the stack. Closes systemd#6147. Many thanks to Walter Doekes for the code review.
evverx
commented
Jun 21, 2017
src/basic/log.c
Outdated
| PROTECT_ERRNO; | ||
| char *buffer, *b; | ||
| size_t l; | ||
| size_t l = LINE_MAX; |
Contributor
Author
There was a problem hiding this comment.
I should probably get rid of l and always use LINE_MAX. I will fix that.
Member
There was a problem hiding this comment.
Yeah, looks good, once l is gone.
Contributor
Author
There was a problem hiding this comment.
I am sorry for the delay. I have just updated the PR. Please take a look.
evverx
added
the
reviewed/needs-rework 🔨
evverx
removed
the
reviewed/needs-rework 🔨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents log_object_internalv from corrupting the stack.
Closes #6147.
Many thanks to Walter Doekes for the code review.