meson: do not link libshared dynamically against libudev#5850
Merged
martinpitt merged 1 commit intosystemd:masterfrom Apr 29, 2017
Merged
meson: do not link libshared dynamically against libudev#5850martinpitt merged 1 commit intosystemd:masterfrom
martinpitt merged 1 commit intosystemd:masterfrom
Conversation
This was referenced Apr 28, 2017
Linking dynamically against libudev will fail once mesonbuild/meson#1545 is merged and apparently already triggers a link failure on s390x. Make libshared provide the udev symbols by including libudev_sources into libshared. This will cause those files to be compiled twice, but it actually reduces the installed size and is closer to what the autotools build system is doing. Closes systemd#5828
martinpitt
approved these changes
Apr 29, 2017
Contributor
martinpitt
left a comment
martinpitt
left a comment
There was a problem hiding this comment.
Cheers! It's great to see CI being green again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linking dynamically against libudev will fail once
mesonbuild/meson#1545 is merged and apparently
already triggers a link failure on s390x.
Make libshared provide the udev symbols by including libudev_sources
into libshared. This will cause those files to be compiled twice, but it
actually reduces the installed size and is closer to what the autotools
build system is doing.
Closes #5828