Allow distributions to override the "localhost" fallback#5175
Merged
martinpitt merged 2 commits intosystemd:masterfrom Jan 31, 2017
Merged
Allow distributions to override the "localhost" fallback#5175martinpitt merged 2 commits intosystemd:masterfrom
martinpitt merged 2 commits intosystemd:masterfrom
Conversation
No reason to capitalize words which are not names. And "nobody" is a user name, traditionally lowercase.
…fallback A configure param is added to make this easy to change if distributions want to differentiate on that. The default remains unchanged. https://bugzilla.redhat.com/show_bug.cgi?id=1392925#c10
Member
|
I am not sure what the usecase for this is precisely? However, do note, that at boot we default to "localhost" still if /etc/hostname is not set. See hostname_setup() in hostname-setup.c... @keszybz are you sure this patch actually does what you want it to do? |
Contributor
Branding, amongst other things. This is a fairly cheap way to change the default hostname, making it more recognisable. For example, you could ssh into a Fedora VM as "root@fedora" rather than anything more complicated. |
Member
|
@hadess but that's not what this patch is doing. If the hostname is not set (i.e. /etc/hostname missing), we'll still default to "localhost"... That's what I am not grokking here... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A configure param is added to make this easy to change if distributions want to differentiate on that. The default remains unchanged.
https://bugzilla.redhat.com/show_bug.cgi?id=1392925#c10