Conversation
Otherwise systemd-user@ fails because systemd validates the account Fixes: systemd#4342
martinpitt
left a comment
martinpitt
left a comment
There was a problem hiding this comment.
Looks good in general, but the help string needs fixing. Thanks!
DISTRO_PORTING
Outdated
| /etc/security/limits.conf will not be read unless you load pam_limits. | ||
| Make sure you add modules your distro expects from user services. | ||
|
|
||
| Pass --with-pamconfdir=no to ./configure installing this file and |
There was a problem hiding this comment.
s/installing/to not install/ ?
| # | ||
| # Used by systemd --user instances. | ||
|
|
||
| account required pam_unix.so |
There was a problem hiding this comment.
If ew add pam_unix in for "account", shouldn't we also add it in for the others?
(i don't know want to suggest we should, I am just wondering this myself)
There was a problem hiding this comment.
pam_unix(8) says:
The session component of this module logs when a user logins or leave the system.
Not very relevant for our purposes.
Also, I don't see why the password and auth modules are relevant. systemd --user has no way to ask the user for feedback (eg, change or input the password).
configure.ac
Outdated
| @@ -1510,6 +1510,7 @@ AC_ARG_WITH([pamconfdir], | |||
| AS_HELP_STRING([--with-pamconfdir=DIR], [Directory for PAM configuration]), | |||
There was a problem hiding this comment.
help text should be updated, i figure
|
Force pushed an updated version, except for adding the other module types for pam_unix |
|
lgtm |
3 participants
Add pam_unix account module to systemd-user pam snippet and enable skipping install of the same snippet.