nss: install nss modules to ${rootlibdir}#4194
Conversation
NSS modules (libnss_*.so.*) need to be installed into
${rootlibdir} (typically /lib) in order to be used. Previously, the
modules were installed into ${libdir}, thus usually ending up in
/usr/lib, even on systems where split usr is enabled, or ${libdir} is
passed explicitly.
Signed-off-by: Maciek Borzecki <[email protected]>
|
Indeed, thanks for fixing this! We have a workaround in our downstream packaging which I've long forgotten about: |
|
There was no such workaround in OE and I ended up tracking why resolved was not used at all. BTW. ubuntu jobs seem to be failing due to this: Is there something I can do about that? |
|
I made the downstream packaging workaround more cautious so that it should now get along with upstream Restarted the failed tests to run against the above fix. |
|
Thanks! |
|
The current Makefile uses the I think explicitly installing into @keszybz , you touched it in commit 24fdc23, do you have an opinion about this? |
|
I think I just refactored the existing code, without thinking about a simpler replacement :( |
|
Sounds good to me. I'll push another patch. |
Replace move-to-rootlibdir calls in post-install hooks with explicitly
used ${rootlibdir} where needed.
Signed-off-by: Maciek Borzecki <[email protected]>
|
In my testing this patch (both the --split-usr and non-split versions) makes no changes to the installation tree. Merging. Ubuntu tests probably need some more adjusting @martinpitt. |
|
24 wrz 2016 18:08 "Zbigniew Jędrzejewski-Szmek" [email protected]
Yeah, split-usr only affects bin/sbin dirs. |
|
"makes no changes" is a good thing — I was just confirming that the installation is same as before with the second patch. Everything is OK afaict. |
The package build scripts do, but I already adjusted them. Thanks! |
NSS modules (libnss__.so._) need to be installed into
${rootlibdir} (typically /lib) in order to be used. Previously, the
modules were installed into ${libdir}, thus usually ending up in
/usr/lib, even on systems where split usr is enabled, or ${libdir} is
passed explicitly.
A similar patch, but backported to 230, will be submitted to OpenEmbedded.