Skip to content

units/[email protected]: use [Install]Alias= instead of static alias#40440

Merged
poettering merged 1 commit intosystemd:mainfrom
keszybz:autovt-install
Jan 24, 2026
Merged

units/[email protected]: use [Install]Alias= instead of static alias#40440
poettering merged 1 commit intosystemd:mainfrom
keszybz:autovt-install

Conversation

@keszybz
Copy link
Member

@keszybz keszybz commented Jan 23, 2026

In Fedora, [email protected] is starting to be used instead of [email protected] to have nicer font handling. This means that we need the [email protected] alias point to the new unit. So far the alias was done through a static symlink because there was little reason to change it. Let's use [Install] instead so the decision which implementation to use can be made after installation.

https://bugzilla.redhat.com/show_bug.cgi?id=2429626 https://fedoraproject.org/wiki/Changes/UseKmsconVTConsole

In Fedora, [email protected] is starting to be used instead of [email protected]
to have nicer font handling. This means that we need the [email protected] alias
point to the new unit. So far the alias was done through a static symlink
because there was little reason to change it. Let's use [Install] instead so
the decision which implementation to use can be made after installation.

https://bugzilla.redhat.com/show_bug.cgi?id=2429626
https://fedoraproject.org/wiki/Changes/UseKmsconVTConsole
@github-actions github-actions bot added build-system units meson please-review PR is ready for (re-)review by a maintainer labels Jan 23, 2026
@YHNdnzj
Copy link
Member

YHNdnzj commented Jan 23, 2026

Please enable it by default in preset. Fedora can override it downstream.

@keszybz
Copy link
Member Author

keszybz commented Jan 23, 2026

Please enable it by default in preset. Fedora can override it downstream.

It is already enabled in presets/90-systemd.preset.

keszybz added a commit to keszybz/kmscon that referenced this pull request Jan 23, 2026
This mirrors the change done in [email protected]:
systemd/systemd#40440. This
way the user can switch between one and the other
by running 'systemctl enable'. Also, the distribution
can use presets to pick the desired implementation.
keszybz added a commit to keszybz/kmscon that referenced this pull request Jan 23, 2026
This mirrors the change done in [email protected]:
systemd/systemd#40440. This
way the user can switch between one and the other
by running 'systemctl enable'. Also, the distribution
can use presets to pick the desired implementation.
@keszybz
Copy link
Member Author

keszybz commented Jan 23, 2026

The debian builds fail with: dh_install: warning: Cannot find (any matches for) "usr/lib/systemd/system/[email protected]" (tried in ., debian/tmp). They'll need to be adjusted.

@poettering poettering added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed please-review PR is ready for (re-)review by a maintainer labels Jan 23, 2026
@poettering poettering merged commit 072e724 into systemd:main Jan 24, 2026
44 of 55 checks passed
@github-actions github-actions bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jan 24, 2026
@bluca
Copy link
Member

bluca commented Jan 24, 2026

The CI was all red here? Now bisecting is broken...

@keszybz keszybz deleted the autovt-install branch January 24, 2026 14:50
keszybz added a commit to keszybz/kmscon that referenced this pull request Jan 26, 2026
This mirrors the change done in [email protected]:
systemd/systemd#40440. This
way the user can switch between one and the other
by running 'systemctl enable'. Also, the distribution
can use presets to pick the desired implementation.
kdj0c pushed a commit to kmscon/kmscon that referenced this pull request Jan 26, 2026
This mirrors the change done in [email protected]:
systemd/systemd#40440. This
way the user can switch between one and the other
by running 'systemctl enable'. Also, the distribution
can use presets to pick the desired implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants