udev,login: update ACL on static device nodes#39071
Merged
poettering merged 2 commits intosystemd:mainfrom Sep 23, 2025
Merged
Conversation
yuwata
force-pushed
the
udev-login-update-acl-on-static-device-nodes
branch
from
df6aaa7 to
ccb0a48
Compare
github-actions
bot
added
the
please-review
yuwata
force-pushed
the
udev-login-update-acl-on-static-device-nodes
branch
from
ccb0a48 to
aad030a
Compare
poettering
reviewed
Sep 23, 2025
| if (acl_calc_mask(&acl) < 0) | ||
| return -errno; | ||
|
|
||
| if (acl_set_file(FORMAT_PROC_FD_PATH(fd), ACL_TYPE_ACCESS, acl) < 0) |
Member
There was a problem hiding this comment.
hmm, i wonder if acl_set_fd() works these days?
(but maybe let's do that independently, in particular to make this simple to break point)
Member
There was a problem hiding this comment.
(the reason we use acl_set_file() here was either some O_PATH messiness around libacl, or because xattr syscalls didn't do fd-based stuff originally, i don't remember. but i think both are nowadays solved in libacl, but dunno)
Member
Author
There was a problem hiding this comment.
Ok, will check and update later in another PR.
poettering
reviewed
Sep 23, 2025
poettering
added
good-to-merge/with-minor-suggestions
and removed
please-review
This effectively reverts 1abb592. No functional change, preparation for the next commit.
In the commit c960ca2, the logic of updating ACL on device node was moved from logind to udevd, but at that time, mistakenly removed the logic for static nodes. Fixes a regression caused by c960ca2 (v258). Fixes systemd#39043.
yuwata
force-pushed
the
udev-login-update-acl-on-static-device-nodes
branch
from
aad030a to
2c762d9
Compare
yuwata
added
good-to-merge/waiting-for-ci 👍
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Member
|
Backport queued for v258.1 |
13 tasks
github-merge-queue bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Oct 20, 2025
This PR systemd/systemd#36444 caused this bug systemd/systemd#39043, which is fixed in this PR systemd/systemd#39071. In short, `uaccess` doesn't work with `OPTIONS+="static_node=..."` udev rules, and `/dev/snd/timer` is a static node. 258.1 needs to wait for the next staging cycle, so for now let's just use a non-static node.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression caused by #36444.
Fixes #39043.