Revert "resolved: don't wait for TLS close_notify replies unnecessarily"#38625
Merged
keszybz merged 1 commit intosystemd:mainfrom Aug 20, 2025
Merged
Revert "resolved: don't wait for TLS close_notify replies unnecessarily"#38625keszybz merged 1 commit intosystemd:mainfrom
keszybz merged 1 commit intosystemd:mainfrom
Conversation
This change introduced a regression that stops DNSOverTLS from working after some time. Revert it for now, as there's no fixup available at the moment. Fixes systemd#38509 This reverts commit 4b6dbd4.
github-actions
bot
added
resolve
please-review
yuwata
approved these changes
Aug 18, 2025
Member
yuwata
left a comment
yuwata
left a comment
There was a problem hiding this comment.
LGTM. Let's wait for 'better' fix for a while.
Member
|
The offending commit is already in v257-stable. Hence, this needs to be also backported to v257-stable. |
github-actions
bot
removed
the
please-review
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduced a regression that stops DNSOverTLS from working after some time. Revert it for now, as there's no fixup available at the moment.
Fixes #38509
This reverts commit 4b6dbd4.
It would be better to have a bug fix, but in case that can't happen in time, we can revert it and it can be retried after the release. If a solution is being worked on, this instead can be closed.