bootctl: replace --no-variables by --variables=BOOL#37144
Merged
poettering merged 1 commit intosystemd:mainfrom Apr 16, 2025
Merged
bootctl: replace --no-variables by --variables=BOOL#37144poettering merged 1 commit intosystemd:mainfrom
poettering merged 1 commit intosystemd:mainfrom
Conversation
poettering
added
sd-boot/sd-stub/bootctl
please-review
yuwata
approved these changes
Apr 15, 2025
Member
yuwata
left a comment
yuwata
left a comment
There was a problem hiding this comment.
LGTM. One super minor comment.
yuwata
added
good-to-merge/with-minor-suggestions
and removed
please-review
poettering
force-pushed
the
efi-set-var-fix
branch
from
224a1d5 to
7db417b
Compare
poettering
added
good-to-merge/waiting-for-ci 👍
YHNdnzj
reviewed
Apr 16, 2025
I think the current behaviour of not doing EFI variables when we are run in a container makes a ton of sense, but in some cases it's useful to do EFI var setup even when a set of namespaces is set up for us, for example to recover a hosed installation from a rescue disk. While we are at it, let's remove some duplicate checks, and systematically output information why we skip various operations. Fixes: systemd#36174 systemd#35005
poettering
force-pushed
the
efi-set-var-fix
branch
from
7db417b to
64460ce
Compare
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the current behaviour of not doing EFI variables when we are run in a container makes a ton of sense, but in some cases it's useful to do EFI var setup even when a set of namespaces is set up for us, for example to recover a hosed installation from a rescue disk.
While we are at it, let's remove some duplicate checks, and systematically output information why we skip various operations.
Fixes: #36174
Fixes: #35005