logind: save seat before applying acl#36408
Merged
poettering merged 1 commit intosystemd:mainfrom Feb 19, 2025
Merged
Conversation
udev will trigger the uaccess program in 73-seat-late.rules, which may modify the device's acl permissions. In some cases, udev triggers the uaccess program when logind is started and active is being set. At this time, 1) logind sets the user's acl permissions, 2) uaccess obtains active and sets acl permissions; 3) logind updates seat's stat_file and writes active. This situation will cause the device to not have the correct acl permissions, resulting in abnormal situations such as a black screen. Therefore, it is necessary to write active to seat's stat file before setting acl.
github-actions
bot
added
login
please-review
Member
github-actions
bot
removed
the
please-review
yuwata
reviewed
Feb 19, 2025
Member
|
-> #36444 |
poettering
added a commit
that referenced
this pull request
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
udev will trigger the uaccess program in 73-seat-late.rules, which may modify the device's acl permissions. In some cases, udev triggers the uaccess program when logind is started and active is being set. At this time, 1) logind sets the user's acl permissions, 2) uaccess obtains active and sets acl permissions; 3) logind updates seat's stat_file and writes active. This situation will cause the device to not have the correct acl permissions, resulting in abnormal situations such as a black screen. Therefore, it is necessary to write active to seat's stat file before setting acl.