boot/stub: allocate pages for combined initrds below 4GiB only on x86#35149
Merged
yuwata merged 3 commits intosystemd:mainfrom Nov 14, 2024
Merged
boot/stub: allocate pages for combined initrds below 4GiB only on x86#35149yuwata merged 3 commits intosystemd:mainfrom
yuwata merged 3 commits intosystemd:mainfrom
Conversation
Outside of x86, some machines (e.g. Apple silicon, AMD Opteron A1100) have physical memory mapped above 4GiB, meaning this allocation will fail, causing the entire boot process to fail on these machines. This commit makes it so that the below-4GB address space allocation requirement is only set on x86 platforms, and not on other platforms (that don't have the specific Linux x86 boot protocol), thereby fixing boot on those that have no memory mapped below 4GiB in their address space. Tested on an Apple silicon M1 laptop and an AMD x86_64 desktop tower. Fixes: systemd#35026
github-actions
bot
added
sd-boot/sd-stub/bootctl
please-review
bluca
approved these changes
Nov 13, 2024
Member
bluca
left a comment
bluca
left a comment
There was a problem hiding this comment.
This is fine for a start, for the next release we can see if we can drop the legacy protocol entirely
bluca
changed the title
bluca
changed the title
Member
|
Can you please add a wrapper xmalloc_initrd() or so? |
Contributor
Author
|
|
bluca
added
the
rc-blocker 🚧
yuwata
approved these changes
Nov 14, 2024
yuwata
added
the
good-to-merge/waiting-for-ci 👍
github-actions
bot
removed
good-to-merge/waiting-for-ci 👍
bluca
removed
the
rc-blocker 🚧
goenkam
pushed a commit
to goenkam/systemd
that referenced
this pull request
Jan 8, 2025
…systemd#35149) Outside of x86, some machines (e.g. Apple silicon, AMD Opteron A1100) have physical memory mapped above 4GiB, meaning this allocation will fail, causing the entire boot process to fail on these machines. This commit makes it so that the below-4GB address space allocation requirement is only set on x86 platforms, and not on other platforms (that don't have the specific Linux x86 boot protocol), thereby fixing boot on those that have no memory mapped below 4GiB in their address space. Tested on an Apple silicon M1 laptop and an AMD x86_64 desktop tower. Fixes: systemd#35026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outside of x86, some machines (e.g. Apple silicon, AMD Opteron A1100) have physical memory mapped above 4GiB, meaning this allocation will fail, causing the entire boot process to fail on these machines.
This commit makes it so that the below-4GB address space allocation requirement is only set on x86 platforms, and not on other platforms (that don't have the specific Linux x86 boot protocol), thereby fixing boot on those that have no memory mapped below 4GiB in their address space.
Tested on an Apple silicon M1 laptop and an AMD x86_64 desktop tower.
Fixes: #35026