udev: set ID_PATH properties for almost all pci, usb, and platform devices#28509
Merged
bluca merged 1 commit intosystemd:mainfrom Jul 25, 2023
Merged
udev: set ID_PATH properties for almost all pci, usb, and platform devices#28509bluca merged 1 commit intosystemd:mainfrom
bluca merged 1 commit intosystemd:mainfrom
Conversation
github-actions
bot
added
the
please-review
bluca
approved these changes
Jul 24, 2023
bluca
added
good-to-merge/waiting-for-reporter-feedback 👍
and removed
please-review
Closed
keszybz
reviewed
Jul 25, 2023
Before c43ff24, the following line in 60-drm.rules also sets ID_PATH for all pci, usb, and platform devices: === ACTION!="remove", SUBSYSTEM=="drm", SUBSYSTEMS=="pci|usb|platform", IMPORT{builtin}="path_id" === Unfortunately, some existing rules rely on the unexpected behavior. To keep the backward compatibility, let's set ID_PATH for them. Fixes systemd#28411.
yuwata
force-pushed
the
udev-rules-set-id-path
branch
from
20f4833 to
5efd7f7
Compare
Member
Author
|
The reporter of the original issue confirmed that the fix works fine. Upgrading the green label. |
yuwata
added
good-to-merge/waiting-for-ci 👍
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Contributor
|
Should probably be backported, so setting the label |
Member
|
This is in v254, so the backport applies only to <254. |
Member
|
I'll take it for 253 and 252 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before c43ff24, the following line in 60-drm.rules also sets ID_PATH for almost all pci, usb, and platform devices:
Unfortunately, some existing rules rely on the unexpected behavior. To keep the backward compatibility, let's set ID_PATH for them.
Fixes #28411.