network: fix fetching link properties #28447
Merged
daandemeyer merged 3 commits intosystemd:mainfrom Jul 19, 2023
Merged
Conversation
github-actions
bot
added
network
tests
please-review
|
An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
yuwata
approved these changes
Jul 18, 2023
yuwata
added
good-to-merge/waiting-for-ci 👍
bluca
approved these changes
Jul 18, 2023
Member
bluca
left a comment
bluca
left a comment
There was a problem hiding this comment.
I guess this might explain:
961s Failed to query link DHCP leases: Invalid argument
961s iface2 Failed to query link bit rates: Invalid argument
961s Failed to query link DHCP leases: Invalid argument
Member
Author
Yep, that's it. |
5 tasks
This fixes regression introduced in 5a0c810 with which all requests for link properties ended up with EINVAL as we kept hitting the signature_is_single() assert in sd_bus_get_property().
Member
Author
|
(quick force push to drop one debug call I forgot about, whoops) |
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes regression introduced in 5a0c810 with which all requests
for link properties ended up with EINVAL as we kept hitting
the signature_is_single() assert in sd_bus_get_property().
+ a couple of tests for other stuff I found while going through coverage reports.