sd-boot: put hashed kernel command line in a PCR of the TPM#2587
Merged
poettering merged 1 commit intosystemd:masterfrom Feb 11, 2016
haraldh:tpmv3
Merged
sd-boot: put hashed kernel command line in a PCR of the TPM#2587poettering merged 1 commit intosystemd:masterfrom haraldh:tpmv3
poettering merged 1 commit intosystemd:masterfrom
haraldh:tpmv3
Conversation
The UEFI BIOS already hashes the contents of the loaded image, so the initrd and the command line of the binary are recorded. Because manually added LoadOptions are not taken into account, these should be recorded also. This patch logs and extends a TPM PCR register with the LoadOptions. This feature can be enabled with configure --enable-tpm The PCR register index can be specified with configure --with-tpm-pcrindex=<NUM>
Member
|
coding-style-wise looks ok to me now. @kaysievers? @msekletar? |
Contributor
|
Looks fine to me. As long as it is off by default, and only for the "distro" to decide to enable it for which of the registers. |
Member
|
ok, merging then |
poettering
added a commit
that referenced
this pull request
Feb 11, 2016
sd-boot: put hashed kernel command line in a PCR of the TPM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UEFI BIOS already hashes the contents of the loaded image, so the
initrd and the command line of the binary are recorded.
Because manually added LoadOptions are not taken into account, these
should be recorded also.
This patch logs and extends a TPM PCR register with the LoadOptions.
This feature can be enabled with configure --enable-tpm
The PCR register index can be specified with
configure --with-tpm-pcrindex=