unit: also prioritize input devices when triggering devices#25144
Merged
poettering merged 1 commit intosystemd:mainfrom Oct 26, 2022
Merged
unit: also prioritize input devices when triggering devices#25144poettering merged 1 commit intosystemd:mainfrom
poettering merged 1 commit intosystemd:mainfrom
Conversation
As in most cases, tty device without input devices is meaningless. This also swaps the priority of tty and net: - input devices are often connected under USB bus, hence may take slightly much time to be initialized. As, described in the above, in most cases it is allowed that tty devices are initialized just before input devices, - network configuration usually requires much time, e.g. DHCP or RA, hence it is better that network interfaces initialized. Then, network services can start DHCP client or friends earlier. Fixes systemd#24026.
bluca
approved these changes
Oct 26, 2022
Member
bluca
left a comment
bluca
left a comment
There was a problem hiding this comment.
Sounds like a regression introduced in 251, so we should merge this for 252 I think?
Member
|
If the reporters report that this improves the situation for them, let's merge immediately. It is always possible that this again will make the situation better for some but worse for others, but it shouldn't break anything, and we're unlikely to get a lot of feedback until this is released anyway. |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in most cases, tty device without input devices is meaningless.
This also swaps the priority of tty and net:
Fixes #24026.