portable: Fix memory leak in maybe_enable_disable() #23483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
portable
Contributor
|
@mrc0mmand I'm wondering why the CI didn't catch it? Is the portabled testsuite skipped on CentOS CI when the tests are run under ASan? |
Member
It is included in the ASan/UBSan list: https://github.com/systemd/systemd-centos-ci/blob/master/vagrant/test_scripts/test-arch-sanitizers-clang.sh#L110. Maybe the test itself doesn't exercise this code path? |
Contributor
Got it. Thanks!
Looks like it. |
yuwata
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23481