file-hierarchy: Document the canonical mountpoint for cgroups #22624
Conversation
|
Seems reasonable to document this. We certainly want to describe a setup with cgroupv2. I'm not sure if we want to describe hybrid and v1 too though. I'll let others comment. |
|
@keszybz Seemed painless to allow for the hybrid setup, insofar as it tells code looking for v2 to consider a fallback to |
keszybz
added
the
reviewed/needs-rework 🔨
file-hierarchy does not mention anything about the expected mountpoint for cgroups. This may lead some software to believe it will need to search for it (e.g. by scanning mountinfo) rather than just looking in the canonical location. Document the canonical mountpoint as /sys/fs/cgroup. Also provide information on the non-default configurations, but make it clear that in such configurations if cgroup2 is mounted (hybrid mode) it won't have resource controllers attached. This will help software know if it should fall back to /sys/fs/cgroup/unified or just ignore that case.
joshtriplett
force-pushed
the
file-hierarchy-document-cgroup-canonical-mountpoint
branch
from
ac7db6c to
a0b34a3
Compare
|
I've updated the PR to more carefully cover hybrid/legacy setups. I've also made it clear that if cgroup2 is mounted on |
yuwata
added
please-review
and removed
reviewed/needs-rework 🔨
|
LGTM. I guess we could add further tweaks, like more hyperlinks, but we can do that separately. |
joshtriplett
deleted the
file-hierarchy-document-cgroup-canonical-mountpoint
branch
file-hierarchy does not mention anything about the expected mountpoint
for cgroups. This may lead some software to believe it will need to
search for it (e.g. by scanning
mountinfo) rather than just looking inthe canonical location.
Document the canonical mountpoint as
/sys/fs/cgroup. Also provide enoughinformation for software looking for
cgroup2to know that it may want tolook under
/sys/fs/cgroup/unifiedas a fallback.