network: add ModemManager support by yuwata · Pull Request #22315 · systemd/systemd

yuwata · 2022-01-31T02:39:15Z

Closes #20370.

src/network/networkd-wwan.h

lgtm-com · 2022-02-01T03:31:40Z

This pull request introduces 1 alert when merging 9facc68 into 9d67fb0 - view on LGTM.com

new alerts:

1 for Use of potentially dangerous function

bluca · 2022-02-18T21:39:58Z

needs a rebase

keszybz

Looks reasonable. I'm a bit surprised that we need to do dbus introspection to figure out the path. @poettering, opinions on that?

src/network/networkd-link.c

src/network/networkd-wwan.h

keszybz · 2022-03-22T10:43:31Z

src/network/networkd-wwan-bus.c

+typedef enum {
+    MM_BEARER_IP_FAMILY_NONE    = 0,
+    MM_BEARER_IP_FAMILY_IPV4    = 1 << 0,
+    MM_BEARER_IP_FAMILY_IPV6    = 1 << 1,
+    MM_BEARER_IP_FAMILY_IPV4V6  = 1 << 2,
+    MM_BEARER_IP_FAMILY_ANY     = 0xFFFFFFFF
+} MMBearerIpFamily;


Wouldn't it be better to just reuse ADDRESS_FAMILY_* for this? The mapping seems to be 1:1 anyway.

No, ADDRESS_FAMILY_YES is 3, not 4.

src/network/networkd-wwan-bus.c

keszybz · 2022-03-22T10:50:35Z

src/network/networkd-wwan.c

+
+                if (b->connected && b->ip4_method == MM_BEARER_IP_METHOD_DHCP) {
+                        if (!link_dhcp4_enabled(link))
+                                log_link_notice(link, "The WWAN connection requested DHCPv4 client, but it is disabled.");


Hmm, IIUC, we log notice but otherwise ignore our own config. I think this is not very useful: we should either let our config take priority here, and not call dhcp4_start(), or we should just ignore our own config. Ideally, we would default link->network->dhcp to ADDRESS_FAMILY_ANY if the support for ModemManager is configured. This would make things "just work", but still allow explicit configuration if wanted.

dhcp4_start() does nothing and returns 0 when DHCP4 client is disabled. So, the current implementation is equivalent to the first suggestion.

keszybz · 2022-03-22T10:54:57Z

src/network/networkd-wwan.c

+                        if (!link_ipv6_accept_ra_enabled(link) && !link_dhcp6_enabled(link))
+                                log_link_notice(link,
+                                                "The WWAN connection requested IPv6 dynamic address configuration,"
+                                                "but both IPv6 Router Discovery and DHCPv6 client are disabled.");


Also here, ndisc_start() and dhcp6_start() do nothing if they are disabled.

Closes systemd#20370.

Heavily based on systemd#22315 by Yu Watanabe. Upstream-Status: Inappropriate [Inappropriate]

Heavily based on systemd#22315 by Yu Watanabe. [Match] Name=wwan* [Network] LLDP=no LinkLocalAddressing=no IPv6AcceptRA=no ModemSimpleConnectProps=apn=internet ip-type=ipv4 allow-roaming=no pin=1111 operator-id=25503 [DHCP] RouteMetric=200 [DHCPv4] UseGateway=yes Upstream-Status: Inappropriate [Inappropriate]

Heavily based on systemd#22315 by Yu Watanabe. [Match] Name=wwan* [Network] LLDP=no LinkLocalAddressing=no IPv6AcceptRA=no ModemSimpleConnectProps=apn=internet ip-type=ipv4 allow-roaming=no pin=1111 operator-id=25503 [DHCP] RouteMetric=200 [DHCPv4] UseGateway=yes Co-authored-by: Yu Watanabe <[email protected]>

Heavily based on systemd#22315 by Yu Watanabe. [Match] Name=wwan* [Network] LLDP=no LinkLocalAddressing=no IPv6AcceptRA=no [ModemManager] SimpleConnectPropertie]s=apn=internet ip-type=ipv4 allow-roaming=no pin=1111 operator-id=25503 RouteMetric=200 UseGateway=yes Co-authored-by: Yu Watanabe <[email protected]>

Heavily based on systemd#22315 by Yu Watanabe. [Match] Name=wwan* [Network] LLDP=no LinkLocalAddressing=no IPv6AcceptRA=no [ModemManager] SimpleConnectProperties=apn=internet ip-type=ipv4 allow-roaming=no pin=1111 operator-id=25503 RouteMetric=200 UseGateway=yes Co-authored-by: Yu Watanabe <[email protected]>

Heavily based on systemd#22315 by Yu Watanabe. [Match] Name=wwan* [Network] LLDP=no LinkLocalAddressing=no IPv6AcceptRA=no [ModemManager] SimpleConnectPropertie]s=apn=internet ip-type=ipv4 allow-roaming=no pin=1111 operator-id=25503 RouteMetric=200 UseGateway=yes Co-authored-by: Yu Watanabe <[email protected]>

yuwata added the network label Jan 31, 2022

yuwata mentioned this pull request Jan 31, 2022

Integration with ModemManager #20370

Closed

github-actions bot added busctl udev labels Jan 31, 2022

yuwata force-pushed the network-wwan branch from 4f07904 to 193dbad Compare January 31, 2022 04:12

yuwata added the new-feature label Jan 31, 2022

yuwata force-pushed the network-wwan branch 4 times, most recently from fb8a7c5 to 1250c2e Compare January 31, 2022 10:39

This comment has been minimized.

Sign in to view

yuwata force-pushed the network-wwan branch from 1250c2e to b94d6fe Compare January 31, 2022 13:51

bluca reviewed Jan 31, 2022

View reviewed changes

src/network/networkd-wwan.h Show resolved Hide resolved

This comment has been minimized.

Sign in to view

yuwata force-pushed the network-wwan branch from b94d6fe to 9facc68 Compare February 1, 2022 02:40

yuwata force-pushed the network-wwan branch from 9facc68 to f55715c Compare February 1, 2022 05:13

bluca added the needs-rebase label Feb 17, 2022

yuwata force-pushed the network-wwan branch from f55715c to f86e0ef Compare February 24, 2022 00:53

yuwata removed the needs-rebase label Feb 24, 2022

yuwata force-pushed the network-wwan branch from f86e0ef to a86e0f5 Compare March 4, 2022 00:39

yuwata force-pushed the network-wwan branch 2 times, most recently from 16285b8 to c76525e Compare March 12, 2022 12:37

yuwata force-pushed the network-wwan branch from c76525e to c05fbcd Compare March 22, 2022 07:07

keszybz reviewed Mar 22, 2022

View reviewed changes

yuwata added 3 commits March 22, 2022 22:41

shared: move busctl/busctl-introspect.[ch] -> shared/bus-parse-xml.[ch]

aed15b0

network: add ModemManager support

acc904f

Closes systemd#20370.

network: support to match .network based on APN

d78072e

yuwata force-pushed the network-wwan branch from c05fbcd to d78072e Compare March 22, 2022 13:54

bluca modified the milestones: v258, v259 Jun 10, 2025

andr2000 pushed a commit to andr2000/systemd that referenced this pull request Sep 3, 2025

network: add ModemManager support

5b95483

Heavily based on systemd#22315 by Yu Watanabe. Upstream-Status: Inappropriate [Inappropriate]

andr2000 mentioned this pull request Sep 8, 2025

Add ModemManager integration with networkd #38855

Merged

bluca removed this from the v259 milestone Nov 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

network: add ModemManager support#22315

network: add ModemManager support#22315
yuwata wants to merge 3 commits intosystemd:mainfrom
yuwata:network-wwan

yuwata commented Jan 31, 2022

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

lgtm-com bot commented Feb 1, 2022

Uh oh!

bluca commented Feb 18, 2022

Uh oh!

keszybz left a comment

Uh oh!

Uh oh!

Uh oh!

keszybz Mar 22, 2022

Uh oh!

yuwata Mar 22, 2022

Uh oh!

Uh oh!

keszybz Mar 22, 2022

Uh oh!

yuwata Mar 22, 2022

Uh oh!

keszybz Mar 22, 2022

Uh oh!

yuwata Mar 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

yuwata commented Jan 31, 2022

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

lgtm-com bot commented Feb 1, 2022

Uh oh!

bluca commented Feb 18, 2022

Uh oh!

keszybz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

keszybz Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

yuwata Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

keszybz Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

yuwata Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

keszybz Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

yuwata Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

10 participants