journal-remote: change owner of and add acl to journal/remote directo…#2212
Closed
yuwata wants to merge 1 commit intosystemd:masterfrom
Closed
journal-remote: change owner of and add acl to journal/remote directo…#2212yuwata wants to merge 1 commit intosystemd:masterfrom
yuwata wants to merge 1 commit intosystemd:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Are those ACLs really necessary?
After all, we already set them in systemd.conf
Member
There was a problem hiding this comment.
No, I don't think we. We used to, but it was changed to non-recursive in 8b258a6.
Member
There was a problem hiding this comment.
Never mind, we set recursive acls on /var/log/journal. So we don't need to duplicate the acl setting on /var/log/journal/remote. This dir would be created after acls were already applied on /var/log/journal, so it should get the right acls. But the ownership should be fixed indeed.
Member
|
@yuwata Can you change the commit to only change the ownership, and skip the acls? |
keszybz
added
the
reviewed/needs-rework 🔨
Member
Author
|
Thank you for the comments. I've pushed the updated request. Please see #2332. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ries.
The service systemd-journal-remote cannot write received journals to /var/log/journal/remote, because of the wrong owner settings of the directory.
This pull requests fixes the owner of the directory, and add ACLs to make administrators can read the journals stored in the directories.