-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
ci: pin labeler #21316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pin labeler #21316
Conversation
Turns out GHActions where `pull_request_target` is used are capable of pwning repositories: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ labeler doesn't check out the source code or build anything so it's safe in its current form but to avoid surprises let's just pin it to the latest version. It's annoying to manage dependencies like this manually so additionally dependabot.yml is introduced to make it easier to keep GHActions up to date more or less automatically: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/keeping-your-actions-up-to-date-with-dependabot
to let Dependabot keep track of them using SHAs codeql-actions doesn't point to SHAs because it isn't clear whether Dependabot supports their release cycle mentioned at github/codeql-action#307
.github/workflows/labeler.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/labeler@main | ||
| - uses: actions/labeler@v3.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging by https://github.com/evverx/systemd/pull/10/files, Dependabot supports pinning GHActions to specific SHAs. I'll try to switch to SHAs instead of tags
|
To be honest, I'm not sure what the point of the labeler action is considering labels often have to be added/updated manually. I'd just drop it and keep Dependabot to make it easier to keep track of the dependencies :-) |
Hah. I didn't know you can use Dependabot for GH Actions, nice! That's definitely something we should have. |
It mostly gets things right for categorization, although with occasional mishaps. So I'd like to keep it, as it's nice to have things labelled for later easy searches |
@bluca got it. Let's keep it then. |
mrc0mmand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
It's a follow-up to systemd#21316. Judging by #36, Dependabot supports their release cycle
Turns out GHActions where
pull_request_targetis used are capableof pwning repositories: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
labeler doesn't check out the source code or build anything so
it's safe in its current form but to avoid surprises let's just pin
it to the latest version. It's annoying to manage dependencies like this
manually so additionally dependabot.yml is introduced to make it
easier to keep GHActions up to date more or less automatically:
https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/keeping-your-actions-up-to-date-with-dependabot
@mrc0mmand could you take a look? Dependabot will create PRs like evverx#10, evverx#12, evverx#11 once the PR is merged.