tests: don't run tests on incomplete setup #2030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Actually, none of these statements is allowed to fail, right? Did you experiment with set -e for these scripts?
Contributor
Author
There was a problem hiding this comment.
set -e breaks these scripts:
$ sudo make clean
TEST CLEANUP: Basic systemd setup
Makefile:8: recipe for target 'clean' failed
make: *** [clean] Error 32
+ test_cleanup
+ umount /var/tmp/systemd-test.otwsn3/root
There are many such places.
Contributor
Author
There was a problem hiding this comment.
I want to use the Unofficial Bash Strict Mode. But it requires many changes.
Member
There was a problem hiding this comment.
I want to use the Unofficial Bash Strict Mode. But it requires many changes.
Fair enough. We should keep that in mind though for future additions.
zonque
added a commit
that referenced
this pull request
Nov 27, 2015
tests: don't run tests on incomplete setup
evverx
added a commit
to evverx/systemd
that referenced
this pull request
Nov 27, 2015
This is a follow-up commit for systemd#1937 See systemd#2030
martinpitt
pushed a commit
to martinpitt/systemd
that referenced
this pull request
Dec 28, 2015
This is a follow-up commit for systemd#1937 See systemd#2030
tblume
pushed a commit
to tblume/systemd-testsuite-suse
that referenced
this pull request
Mar 8, 2016
This is a follow-up commit for systemd/systemd#1937 See systemd/systemd#2030
tblume
pushed a commit
to tblume/systemd-testsuite-suse
that referenced
this pull request
Aug 6, 2018
This is a follow-up commit for systemd/systemd#1937 See systemd/systemd#2030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce:
straceHmmmm...:)
Now:
@zonque , @ronnychevalier , please, take a look.