network: introduce NetworkConfigSource and NetworkConfigState#20226
Merged
yuwata merged 4 commits intosystemd:mainfrom Sep 29, 2021
Merged
network: introduce NetworkConfigSource and NetworkConfigState#20226yuwata merged 4 commits intosystemd:mainfrom
yuwata merged 4 commits intosystemd:mainfrom
Conversation
yuwata
force-pushed
the
network-introduce-source-and-status
branch
3 times, most recently
from
a4906c2 to
8dd414f
Compare
yuwata
force-pushed
the
network-introduce-source-and-status
branch
from
8dd414f to
ef5605e
Compare
yuwata
force-pushed
the
network-introduce-source-and-status
branch
2 times, most recently
from
eb8f510 to
32813cd
Compare
yuwata
changed the title
yuwata
force-pushed
the
network-introduce-source-and-status
branch
13 times, most recently
from
a283434 to
3ebcf0b
Compare
yuwata
force-pushed
the
network-introduce-source-and-status
branch
from
3ebcf0b to
6d2d6d4
Compare
yuwata
force-pushed
the
network-introduce-source-and-status
branch
3 times, most recently
from
aaf83a4 to
2112c43
Compare
yuwata
force-pushed
the
network-introduce-source-and-status
branch
2 times, most recently
from
fe2c1ea to
7571604
Compare
yuwata
force-pushed
the
network-introduce-source-and-status
branch
2 times, most recently
from
2f3fca9 to
283a1b9
Compare
yuwata
force-pushed
the
network-introduce-source-and-status
branch
5 times, most recently
from
b7be9d1 to
d49f751
Compare
yuwata
changed the title
Member
Author
|
Now, this is ready for review. PTAL. Unfortunately, the first commit is quite big, as it changes how networkd manages dynamic addresses and routes. But, hopefully, now the code is simpler to understand. Actually, more than 600 lines are reduced. |
yuwata
force-pushed
the
network-introduce-source-and-status
branch
from
d49f751 to
397f11a
Compare
Now, link_drop_foreign_config() drops subset of configs which can be dropped by link_drop_config().
yuwata
force-pushed
the
network-introduce-source-and-status
branch
from
397f11a to
b4c7934
Compare
This was referenced Sep 24, 2021
Member
|
So, I'd lie if I really followed what all those changes in the first commit too, but I didn't find anything wrong with it code-wise. lgtm hence. |
poettering
added
good-to-merge/waiting-for-ci 👍
Member
Author
|
@poettering Thank you. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.