Revert "systemctl: return EXIT_SUCCESS on success"#1845
Conversation
This reverts commit 6a32563.
|
Yikes. Good point. Probably should be a comment there as this is non-standard (or maybe there was one I didn't see). |
Revert "systemctl: return EXIT_SUCCESS on success"
|
My daily integration tests were yelling at me, and confirming that this fixes stuff again. Thanks! 👍 |
|
oh, sorry. hm,
@martinpitt , where can I find these tests? I mean, I changed a |
…nd of main() To avoid confusion as outlined in systemd#1845.
|
@evverx : They are in http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/tree/debian/tests . They are downstream integration tests using the built packages, so running them in an upstream context is not entirely straightforward. One test that failled on this was http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/tree/debian/tests/unit-config , this should actually work reasonably well by just directly calling it in a VM. |
|
@martinpitt , thanks. I'll
oh, I know. |
This reverts commit 6a32563.
Make sure we continue to return LSB compatible exit codes.
@teg @evverx please have a look