man: extend time-{set,sync}.target + systemd-timesyncd/wait-sync docs #18048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @Minoru |
bluca
added
documentation
units
good-to-merge/waiting-for-ci 👍
Minoru
reviewed
Dec 21, 2020
Contributor
Minoru
left a comment
Minoru
left a comment
There was a problem hiding this comment.
Thank you! This achieves the intent of my PR much more thoroughly than I could.
I left a few comments where I think the doc could be less abstruse or more precise — please see below.
bluca
added
good-to-merge/with-minor-suggestions
and removed
good-to-merge/waiting-for-ci 👍
Co-authored-by: Alexander Batischev <[email protected]>
poettering
force-pushed
the
timesync-man-more
branch
from
ca071a5 to
57b3b8f
Compare
Member
Author
|
Force pushed a new version. Applied all of @Minoru's suggested changes (thanks!). No other changes. Since this all is documentation, and changes were relatively minor, taking liberty to upgrade green label. Thanks! |
poettering
added
good-to-merge/waiting-for-ci 👍
Member
|
Given it's manpages-only, no need to wait for the slow bionic-* CI suites, and the rest is green, so merging. |
bluca
added
documentation
and removed
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's link the three man pages together more tightly and explain what
the two targets are about, emphasizing local/quick/reliable/approximate
vs remote/slow/unreliable/accurate synchronization.
Follow-up for: 1431b2f fe934b4