cgroup: Parse infinity properly for memory protections #16265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes commit db2b8d2 that rectified parsing empty values but broke parsing explicit infinity. Intended parsing semantics will be captured in a testcase in a follow up commit. Ref: systemd#16248
This covers parsing from configuration files only. Properties set via DBus have separate code path whose testing would require DBus setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Apologies for confusion around #16122 and #16248)
Reviewing once again I spotted this bug in the second patch originally in #16058.
I post a fixup accompanied with a test. (Similar logic is replicated both in
load-fragment.candbus-unit-util.c(for other properties too), which would be worth refactoring and unifying, however, that'd be much bigger change. So far, the DBus variant is uncovered (and unaffected by this bug).)