Revert "cgroup: Allow empty assignments of Memory{Low,Min}=" #16248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 53aa85a. The reason is that that patch changes the dbus api to be different than the types declared by introspection api. Replaces systemd#16122.
Contributor
|
LGTM (following the discussion in #16122). |
Werkov
added a commit
to Werkov/systemd
that referenced
this pull request
Jun 24, 2020
This fixes commit 66a892a that rectified parsing empty values but broke parsing explicit infinity. Intended parsing semantics will be captured in a testcase in a follow up commit. Ref: systemd#16248
Werkov
added a commit
to Werkov/systemd
that referenced
this pull request
Jun 24, 2020
This fixes commit db2b8d2 that rectified parsing empty values but broke parsing explicit infinity. Intended parsing semantics will be captured in a testcase in a follow up commit. Ref: systemd#16248
Werkov
added a commit
to Werkov/systemd
that referenced
this pull request
Jun 24, 2020
This fixes commit db2b8d2 that rectified parsing empty values but broke parsing explicit infinity. Intended parsing semantics will be captured in a testcase in a follow up commit. Ref: systemd#16248 (cherry picked from commit 67e2baf) [mkoutny: fixes bsc#1167471] [mkoutny: dropped parts for MemoryMin,DefaultMemory{Min,Low}]
Werkov
added a commit
to Werkov/systemd
that referenced
this pull request
Jul 9, 2020
This fixes commit db2b8d2 that rectified parsing empty values but broke parsing explicit infinity. Intended parsing semantics will be captured in a testcase in a follow up commit. Ref: systemd#16248 (cherry picked from commit 67e2baf) [mkoutny: fixes bsc#1167471] [mkoutny: dropped parts for MemoryMin,DefaultMemory{Min,Low}]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 53aa85a.
The reason is that that patch changes the dbus api to be different than
the types declared by introspection api.
Replaces #16122.