network: tc: add several settings for HTB #16093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pesa
reviewed
Jun 9, 2020
poettering
requested changes
Jun 9, 2020
Member
poettering
left a comment
poettering
left a comment
There was a problem hiding this comment.
i think we should try to stick to the rule that time values are always called "XyzSec" and byte values are called "XyzBytes=". We aren't good at that so far, but let's at least do that for new stuff...
poettering
added
the
reviewed/needs-rework 🔨
ssahani
reviewed
Jun 10, 2020
yuwata
force-pushed
the
network-htb-add-settings-15213
branch
from
2ec6cc7 to
2ee7e54
Compare
Member
Author
|
@Pesa and @poettering Thank you for the review. I've force-pushed an updated version. I hope all points are addressed. PTAL. |
yuwata
removed
the
reviewed/needs-rework 🔨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15213.