Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: fix CI failure #13577

Merged
merged 2 commits into from
Sep 17, 2019
Merged

network: fix CI failure #13577

merged 2 commits into from
Sep 17, 2019

Conversation

yuwata
Copy link
Member

@yuwata yuwata commented Sep 17, 2019

@yuwata
network: add missing link->network checks
b1b0b42 
When the function is called, no network file may be assigned to the
link.
@yuwata
network: do not enter failed state if device's sysfs entry does not e…
4d59e14 
…xist yet
@yuwata yuwata added the network label Sep 17, 2019
@mrc0mmand mrc0mmand mentioned this pull request Sep 17, 2019
Merged
@keszybz keszybz added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Sep 17, 2019
@keszybz
Copy link
Member

keszybz commented Sep 17, 2019

LGTM.

@mrc0mmand
Copy link
Member

The bionic-arm64 failure is the same I mentioned in #13575 (comment). I have no idea what's going on there...

@mrc0mmand mrc0mmand merged commit 59a224d into systemd:master Sep 17, 2019
@yuwata yuwata deleted the network-fix-ci-failure branch September 17, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-failure-appears-unrelated good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed network
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuwata @keszybz @mrc0mmand