-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
man: let's deprecate PermissionsStartOnly= #10802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The concept is redundant and predates the special chars that do the same in ExecStar=. Let's settle on advertising just the latter, and hide PermissionsStartOnly= from the docs (even if we continue supporting it).
keszybz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be removed from docs/TRANSIENT-SETTINGS.md.
| SD_BUS_PROPERTY("WatchdogUSec", "t", bus_property_get_usec, offsetof(Service, watchdog_usec), SD_BUS_VTABLE_PROPERTY_CONST), | ||
| BUS_PROPERTY_DUAL_TIMESTAMP("WatchdogTimestamp", offsetof(Service, watchdog_timestamp), 0), | ||
| SD_BUS_PROPERTY("PermissionsStartOnly", "b", bus_property_get_bool, offsetof(Service, permissions_start_only), SD_BUS_VTABLE_PROPERTY_CONST), | ||
| SD_BUS_PROPERTY("PermissionsStartOnly", "b", bus_property_get_bool, offsetof(Service, permissions_start_only), SD_BUS_VTABLE_PROPERTY_CONST|SD_BUS_VTABLE_HIDDEN), /* 😷 deprecated */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😷 — wow.
|
https://codesearch.debian.net/search?q=PermissionsStartOnly%3D&perpkg=1 Are there plans to drop PermissionsStartOnly eventually? If so, I'd have to get those affected updated... |
Dunno, we might consider doing this one day, but doesn't appear like something to do soon. I mean there's also RootDirectoryStartOnly=, which we probably should handle the same way, but it has no counterpart yet, hence really too early to get rid of either entirely. |
|
Ok, when you do actually intend to remove that option, please give us (downstream distros) a heads-up soon enough. |
|
This deprecation does not seem to be mentioned in any changelog / |
|
Added to #11387. |
systemd/systemd#10802 (comment) (cherry picked from commit 455027c)
Since PermissionsStartOnly is deperecated, we need to use new format on ExecStartPre / ExecStopPost, a special executable prefix '+'. (which means the command will run in full privilege) see systemd/systemd#10802 see https://man7.org/linux/man-pages/man5/systemd.service.5.html Related with scylladb/scylla-enterprise#1067
Since PermissionsStartOnly is deperecated, we need to use new format on ExecStartPre / ExecStopPost, a special executable prefix '+'. (which means the command will run in full privilege) However, older distribution like CentOS7 does not support the prefix '+', so we need to keep using PermissionsStartOnly (these are systemd < v231). see systemd/systemd#10802 see https://man7.org/linux/man-pages/man5/systemd.service.5.html Related with scylladb/scylla-enterprise#1067
Replace the deprecated PermissionsStartOnly option in favour of the supported method of elevating the exec commands. systemd/systemd#10802 (comment)
- elevate Prestart and Poststop script permissions using "+" prefix instead, as per https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Command%20lines ( PermissionsStartOnly was deprecated in systemd 241 and no longer appears in documentation since 2018 systemd/systemd#10802 ) Signed-off-by: Rob Gill <[email protected]>
The concept is redundant and predates the special chars that do the same
in ExecStar=. Let's settle on advertising just the latter, and hide
PermissionsStartOnly= from the docs (even if we continue supporting it).