Merged
Conversation
HofiOne
force-pushed
the
kafka-source
branch
4 times, most recently
from
3286483 to
ff38c20
Compare
HofiOne
force-pushed
the
kafka-source
branch
5 times, most recently
from
c8c238a to
3831b89
Compare
HofiOne
force-pushed
the
kafka-source
branch
12 times, most recently
from
6ea9053 to
32c4dc4
Compare
…inear consuming Signed-off-by: Hofi <[email protected]>
…ka bug) at startup without a connection Signed-off-by: Hofi <[email protected]>
…amed to ignore_saved_bookmarks and synced its handling in the persist state maintenance Signed-off-by: Hofi <[email protected]>
…d to ignore_saved_bookmarks Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
…, store owner references Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
… the already exiting nameing convention Signed-off-by: Hofi <[email protected]>
…the rebalance event correctly, synced instead Signed-off-by: Hofi <[email protected]>
…fully reinitiation of the consumer (will not always work) Signed-off-by: Hofi <[email protected]>
…he persist is invalidated, as those are not affected by the remote connection/partition assignment state Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
therandomstring
requested changes
Feb 11, 2026
Contributor
therandomstring
left a comment
therandomstring
left a comment
There was a problem hiding this comment.
I'll do a second review round if time permits.
Signed-off-by: Hofi <[email protected]>
Collaborator
Author
ready for it |
Contributor
therandomstring
left a comment
therandomstring
left a comment
There was a problem hiding this comment.
In this round I focused more on unused imports and functions. I still want to do a once-over on the logic itself.
Signed-off-by: Hofi <[email protected]>
therandomstring
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #5330
TODO: