network-load-balancer: add support for failover#5562
Merged
HofiOne merged 6 commits intosyslog-ng:developfrom Nov 12, 2025
Merged
network-load-balancer: add support for failover#5562HofiOne merged 6 commits intosyslog-ng:developfrom
HofiOne merged 6 commits intosyslog-ng:developfrom
Conversation
The confgen script for `network-load-balancer` now supports failover, generating the list of failover servers for each destination automatically. Signed-off-by: Daniele Ferla <[email protected]>
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
Ensure that scl scripts maintain the execute flag when using cmake Signed-off-by: Daniele Ferla <[email protected]>
Signed-off-by: Daniele Ferla <[email protected]>
Signed-off-by: Daniele Ferla <[email protected]>
1feb080 to
8878dce
Compare
Signed-off-by: Daniele Ferla <[email protected]>
8878dce to
09d43bc
Compare
Collaborator
|
@egglessness I absolutely love this, thank you! Let me ask for one more tiny improvement. |
HofiOne
approved these changes
Nov 12, 2025
Contributor
Author
|
Hi @HofiOne, thank you! |
Collaborator
Perfect, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1210
The confgen script for
network-load-balancernow supports failover, generating the list of failover servers for each destination automatically.Although this feature has been initially implemented in #1706, it was left commented (#1706 (comment)) since at that time failover support was available only in PE6.
Instead of just commenting it out, I decided to rewrite the script to implement the following enhancements:
failover(servers())syntax, instead of the deprecatedfailover-servers()blockR_USECinstead ofR_MSECto distribute incoming messages more evenlyOn top of that, the script tries to be as flexible as possible:
failover(off)orfailover(no)failback())I also added some tests to ensure this confgen script keeps up with upcoming features in the next releases. :)
Usage example
The following snippet:
... gets rendered as follows: