afsocket-source: Workaround of socket reopen failure on config reload#5552
Merged
HofiOne merged 3 commits intosyslog-ng:developfrom Nov 4, 2025
Merged
Conversation
HofiOne
changed the title
HofiOne
changed the title
HofiOne
force-pushed
the
fix-socket-reopen-on-config-reload
branch
from
5695282 to
1485de6
Compare
HofiOne
force-pushed
the
fix-socket-reopen-on-config-reload
branch
7 times, most recently
from
e7b6356 to
50445d7
Compare
HofiOne
force-pushed
the
fix-socket-reopen-on-config-reload
branch
3 times, most recently
from
32168b1 to
b993e56
Compare
kovgeri01
approved these changes
Oct 30, 2025
kovgeri01
suggested changes
Oct 30, 2025
Contributor
kovgeri01
left a comment
kovgeri01
left a comment
There was a problem hiding this comment.
please check he name of the news file
HofiOne
added a commit
to HofiOne/syslog-ng
that referenced
this pull request
Oct 30, 2025
Signed-off-by: Hofi <[email protected]>
HofiOne
force-pushed
the
fix-socket-reopen-on-config-reload
branch
from
b993e56 to
ad4760b
Compare
HofiOne
added a commit
to HofiOne/syslog-ng
that referenced
this pull request
Oct 30, 2025
Signed-off-by: Hofi <[email protected]>
HofiOne
force-pushed
the
fix-socket-reopen-on-config-reload
branch
from
ad4760b to
a805ead
Compare
Contributor
|
Build FAILURE |
Contributor
|
Build FAILURE |
2 similar comments
Contributor
|
Build FAILURE |
Contributor
|
Build FAILURE |
Collaborator
Author
|
@kira-syslogng test this please test test=functions/destination-drivers/http-destination-driver/024-http-reload-restore-init-error.zts; branch=fix-http-reopen-test; |
…ust like in apply Signed-off-by: Hofi <[email protected]>
…ive(no) from yes, and the newly loaded config socket instance cannot be opened (as the old one still keeps it open) Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
HofiOne
force-pushed
the
fix-socket-reopen-on-config-reload
branch
from
a805ead to
c30db5f
Compare
Contributor
|
Build FAILURE |
kovgeri01
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
afsocket-source: Added a workaround for the issue where a reload switches fromkeep-alive(yes)tokeep-alive(no)withso-reuseport(no), causing the newly loaded config’s socket instance to fail to open.The current solution restores the existing connections during the first config reload if stored connections are present — effectively treating it as if
keep-alive(yes)were selected.This ensures that connections are properly maintained, but it also means that the new config’s
keep-alive(no)setting is ignored during the first reload (subsequent reloads will correctly respect it).This behavior is still more acceptable than the original issue, where no connection could be established, the config reload was interrupted, and the new configuration was not applied at all.
See the code comments for more.