Add a filter for blank values#5425
Merged
therandomstring merged 1 commit intosyslog-ng:developfrom Aug 5, 2025
Merged
Conversation
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
smortex
force-pushed
the
add-blank-filter
branch
8 times, most recently
from
87237b1 to
539df30
Compare
smortex
force-pushed
the
add-blank-filter
branch
from
539df30 to
327597c
Compare
Contributor
Author
|
CI issues should be fixed now. I will squash commits on request when this work is ready. |
Contributor
|
Thank you for the contribution. I'll try to review it today. |
therandomstring
requested changes
Aug 1, 2025
therandomstring
approved these changes
Aug 4, 2025
Contributor
|
@smortex a squash would be welcome, but otherwise LGTM. Approved. |
A value is considered blank if it is not set, is an empty string, is an empty list, is a string with only whitespace, or is boolean false. Signed-off-by: Romain Tartière <[email protected]>
smortex
force-pushed
the
add-blank-filter
branch
from
eb4fc8d to
26cd25d
Compare
Contributor
Author
|
Squashed thanks! |
Contributor
|
@kira-syslogng test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of a discussion on the syslog-ng chat.
A value is considered blank if it is not set, is an empty string, is an empty list, is a string with only whitespace, or is boolean false.