affile: add exclude-pattern() option to wildcard-file()#5416
affile: add exclude-pattern() option to wildcard-file()#5416HofiOne merged 2 commits intosyslog-ng:developfrom
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
overhacked
force-pushed
the
overhacked/wildcard-exclusion
branch
from
e786a29 to
14ebec0
Compare
|
@overhacked Thank you for your contribution. I will check it soon. |
This Pull Request introduces config grammar changessyslog-ng/86cd95766159aa14b20569f55b78f72012da7b49 -> overhacked/overhacked/wildcard-exclusion Details--- a/source
+++ b/source
wildcard-file(
+ exclude-pattern(<string>)
)
|
There was a problem hiding this comment.
@overhacked Apart from the 2 tiny style-check issues, it LGTM, nice job, thank you!
NOTE: You can ignore the FreeBSD error; it is (hopefully temporarily)a problem in the current state of the v15 ports.
modules/affile/wildcard-source.c
Outdated
| static gboolean | ||
| _init_exclude_pattern(WildcardSourceDriver *self) | ||
| { | ||
| if (self->exclude_pattern) { |
There was a problem hiding this comment.
Style check fails on this, please correct
Add ability to refine wildcard-file( filename-pattern() ) option with exclude-pattern() to exclude some matching files. Example: match all *.log but exclude *.?.log. Signed-off-by: Ross Williams <[email protected]>
Signed-off-by: Ross Williams <[email protected]>
overhacked
force-pushed
the
overhacked/wildcard-exclusion
branch
from
14ebec0 to
fb9fdf5
Compare
|
@HofiOne I fixed and rebased with the style corrections, but CI didn't seem to automatically re-run. Also, I did run |
Add documentation for syslog-ng/syslog-ng#5416 (merged).
3 participants
Add ability to refine
wildcard-file( filename-pattern() )option withexclude-pattern()to exclude some matching files. Example: match all*.logbut exclude*.?.log.A new option for the wildcard-file source is added and a new functional test that ensures
exclude-pattern()works is included intests/functional. The new test is a separate test file, becauseexclude-patterndoesn't need to be tested with the samepoll/autoconfiguration variants that the rest of theaffiletests need to be exercised with.The implementation is just a new option in the module's config parser and one new logic test in
modules/affile/wildcard-source.c:_handle_file_created().