Implement rfc6587 auto detection#5322
Merged
HofiOne merged 13 commits intosyslog-ng:developfrom Apr 22, 2025
Merged
Conversation
HofiOne
force-pushed
the
implement-rfc6587-auto-detection
branch
from
9cbf03e to
c4c5fe2
Compare
Contributor
|
Build FAILURE |
Contributor
|
@kira-syslogng retest this please |
Contributor
|
Build FAILURE |
HofiOne
force-pushed
the
implement-rfc6587-auto-detection
branch
from
c4c5fe2 to
fe5612c
Compare
Contributor
|
Build FAILURE |
…e is 0 Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
…ogTransport instances Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
…lected Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
This is just the change in test code, which adds LogProtoServer ** arguments to the handshake related functions, in order to allow log_proto_server_handshake to change the LogProto instance. Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
This can be used to simplify LogProtoAutoServer. Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: Hofi <[email protected]>
HofiOne
force-pushed
the
implement-rfc6587-auto-detection
branch
from
fe5612c to
3dad57d
Compare
Contributor
This Pull Request introduces config grammar changessyslog-ng/5c20d41c571702f5bf50671e4b18a306e3790d5e -> HofiOne/implement-rfc6587-auto-detection Details--- a/destination
+++ b/destination
network(
transport(
+ auto
)
)
syslog(
transport(
+ auto
)
)
--- a/source
+++ b/source
network(
transport(
+ auto
)
)
syslog(
transport(
+ auto
)
)
|
Contributor
|
Build FAILURE |
kovgeri01
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty common misconfiguration that should be handled automatically.
Just use syslog(transport(auto)) to automatically accept both octet counted and non-octet counted connections, this opens a TCP port without TLS, meaning it is an implementation of RFC6587.
Backport of by @bazsi
Depends on #5321