Skip to content

S3 updates#5286

Merged
HofiOne merged 5 commits intosyslog-ng:developfrom
therandomstring:s3-updates
May 30, 2025
Merged

S3 updates#5286
HofiOne merged 5 commits intosyslog-ng:developfrom
therandomstring:s3-updates

Conversation

@therandomstring
Copy link
Contributor

@therandomstring therandomstring commented Mar 20, 2025 •
edited
Loading

This pull request introduces two new options for s3:

  • content-type(): users now can change the displayed content type of their logs.
  • use_compression(): in version 1.36 botocore developers changed the default integrity check settings (see Announcement: S3 default integrity change boto/boto3#4392). This option allows the users to change the default when_supported value to when_required for S3 compatible solutions that don't support checksums.

Usage:

s3(
	url("http://localhost:9000")
	bucket("testbucket")
	object_key("testobject")
	access_key("<ACCESS_KEY_ID>")
	secret_key("<SECRET_ACCESS_KEY>")
	content_type("text/plain")
	use_checksum("when_required")
);

Based on 408, 486 and 488 by @alltilla

therandomstring added a commit to therandomstring/syslog-ng that referenced this pull request Mar 20, 2025
@therandomstring
news: Added feature entry for syslog-ng#5286
3695f97 
Signed-off-by: Bálint Horváth <[email protected]>
@therandomstring therandomstring marked this pull request as ready for review March 20, 2025 13:49
HofiOne
HofiOne requested changes Mar 20, 2025
View reviewed changes
therandomstring added a commit to therandomstring/syslog-ng that referenced this pull request Mar 20, 2025
@therandomstring
news: Added feature entry for syslog-ng#5286
06257c1 
Signed-off-by: Bálint Horváth <[email protected]>
@therandomstring
python/s3-dd: Enabled buffer loading to keep default values for metad…
c81a606 
…ata elements.

This should allow for easier introduction of new config elements without breaking old buffers still on the disk.

Signed-off-by: Bálint Horváth <[email protected]>
@therandomstring
python/s3-dd: Added option for content-type
1acb9b5 
Commit based on axoflow/axosyslog#408

Signed-off-by: Bálint Horváth <[email protected]>
@therandomstring
python/s3-dd: Moved extra_args ta separate variable
eba7352 
Signed-off-by: Bálint Horváth <[email protected]>
@therandomstring
python/s3-dd: Added option to change default S3 checksum validation b…
abf7143 
…ehaviour

This option requires botocore 1.36 or above.
Commit based on axoflow/axosyslog#486 and axoflow/axosyslog#488

Signed-off-by: Bálint Horváth <[email protected]>
therandomstring added a commit to therandomstring/syslog-ng that referenced this pull request Mar 21, 2025
@therandomstring
news: Added feature entry for syslog-ng#5286
4232528 
Signed-off-by: Bálint Horváth <[email protected]>
HofiOne
HofiOne requested changes May 26, 2025
View reviewed changes
therandomstring added a commit to therandomstring/syslog-ng that referenced this pull request May 26, 2025
@therandomstring
squash! news: Added feature entry for syslog-ng#5286
c7de2f8 
Signed-off-by: Bálint Horváth <[email protected]>
@kira-syslogng
Copy link
Contributor

kira-syslogng commented May 26, 2025

Build FAILURE

@HofiOne HofiOne mentioned this pull request May 28, 2025
Closed
@HofiOne HofiOne merged commit a403f4d into syslog-ng:develop May 30, 2025
33 of 36 checks passed
@sodomelle sodomelle mentioned this pull request Sep 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HofiOne HofiOne HofiOne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@therandomstring @kira-syslogng @HofiOne