otel: fix multi-worker window and fetch-limit calculation#5138
Merged
HofiOne merged 3 commits intosyslog-ng:masterfrom Sep 27, 2024
Merged
otel: fix multi-worker window and fetch-limit calculation#5138HofiOne merged 3 commits intosyslog-ng:masterfrom
HofiOne merged 3 commits intosyslog-ng:masterfrom
Conversation
This also fixes opentelemetry() and axosyslog-otlp() when workers() > 1, because originally init_window_size was always set to 0 (-1 / num_workers). Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
kovgeri01
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
init_window_size was always 0 when workers() was set to >1, because it was placed too early in the init() method: -1 / num_workers .
Backport of #310 by @MrAnno