diskq/diskq-global-metrics: use metrics cache to keep counters alive#5073
Merged
HofiOne merged 2 commits intosyslog-ng:masterfrom Aug 27, 2024
Merged
Conversation
HofiOne
force-pushed
the
global-disk-buffer-metrics-fix
branch
from
bcb0234 to
3ca7b03
Compare
HofiOne
force-pushed
the
global-disk-buffer-metrics-fix
branch
from
3ca7b03 to
9c8ac38
Compare
Signed-off-by: Attila Szakacs <[email protected]> Signed-off-by: Hofi <[email protected]>
We do not show the orphaned metrics in the prometheus stats output. Registering, incrementing then unregistering the counter makes it orphaned. This can be solved with binding the lifecycle of the counters to the diskq_global_metrics instance. Signed-off-by: Attila Szakacs <[email protected]> Signed-off-by: Hofi <[email protected]>
HofiOne
force-pushed
the
global-disk-buffer-metrics-fix
branch
from
9c8ac38 to
ef5592c
Compare
therandomstring
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #5072
We do not show the orphaned metrics in the prometheus stats output. Registering, incrementing then unregistering
the counter makes it orphaned.
This can be solved with binding the lifecycle of the counters to the diskq_global_metrics instance.
No news file entry is needed, the counters disappeared after 4.7 was released.
Backport of #182 by @alltilla