http: bind output_http_requests_total counter lifecycle to worker's #5072
Merged
HofiOne merged 2 commits intosyslog-ng:masterfrom Aug 27, 2024
Merged
http: bind output_http_requests_total counter lifecycle to worker's #5072HofiOne merged 2 commits intosyslog-ng:masterfrom
HofiOne merged 2 commits intosyslog-ng:masterfrom
Conversation
HofiOne
force-pushed
the
http-request-metrics-fix
branch
from
6106cad to
2ba34ff
Compare
HofiOne
dismissed
therandomstring’s stale review
The merge-base changed after approval.
therandomstring
previously approved these changes
Aug 27, 2024
therandomstring
previously approved these changes
Aug 27, 2024
HofiOne
dismissed
therandomstring’s stale review
The merge-base changed after approval.
therandomstring
approved these changes
Aug 27, 2024
therandomstring
previously approved these changes
Aug 27, 2024
HofiOne
dismissed
therandomstring’s stale review
The merge-base changed after approval.
The metrics TLS cache binds the lifecycle of the counters to the lifecycle of the thread, which is the same as the process's. There are cases where a cache like this is useful, but we want to bind the lifecycle of the counters to a different entity, like a HTTP worker. Signed-off-by: Attila Szakacs <[email protected]> Signed-off-by: Hofi <[email protected]>
We do not show the orphaned metrics in the prometheus stats output. Registering, incrementing then unregistering the counter makes it orphaned. This can be solved with binding the lifecycle of the counters to the worker. Signed-off-by: Attila Szakacs <[email protected]> Signed-off-by: Hofi <[email protected]>
HofiOne
force-pushed
the
http-request-metrics-fix
branch
from
2ba34ff to
b8a5533
Compare
therandomstring
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #5071
We do not show the orphaned metrics in the prometheus stats output. Registering, incrementing then unregistering the counter makes it orphaned.
This can be solved with binding the lifecycle of the counters to the worker.
No news file entry is needed, the counters disappeared after 4.7 was released.
Backport of #180 by @alltilla