Skip to content

affile: Check if EOF checking is possible with lseek before adding checker#5058

Merged
kovgeri01 merged 1 commit intosyslog-ng:masterfrom
kovgeri01:check_if_fd_checking_is_possible_before_adding_eof_checker
Aug 23, 2024
Merged

affile: Check if EOF checking is possible with lseek before adding checker#5058
kovgeri01 merged 1 commit intosyslog-ng:masterfrom
kovgeri01:check_if_fd_checking_is_possible_before_adding_eof_checker

Conversation

@kovgeri01
Copy link
Contributor

@kovgeri01 kovgeri01 commented Aug 7, 2024 •
edited by HofiOne
Loading

Resolves #5057

@kovgeri01 kovgeri01 force-pushed the check_if_fd_checking_is_possible_before_adding_eof_checker branch 5 times, most recently from 1c6a8bf to 5fbfb70 Compare August 8, 2024 13:54
@egtvedt egtvedt mentioned this pull request Aug 19, 2024
Closed
@kovgeri01 kovgeri01 marked this pull request as ready for review August 21, 2024 07:35
@kovgeri01 kovgeri01 force-pushed the check_if_fd_checking_is_possible_before_adding_eof_checker branch from 5fbfb70 to 44afdf6 Compare August 21, 2024 07:49
@kovgeri01
Copy link
Contributor Author

kovgeri01 commented Aug 21, 2024

@kira-syslogng test this please test branch=test-pipe-source;

HofiOne
HofiOne reviewed Aug 23, 2024
View reviewed changes
@HofiOne
Copy link
Collaborator

HofiOne commented Aug 23, 2024 •
edited
Loading

I do not know if it's possible, but could you please add some tests that cover pipe usage as well?

@kovgeri01
Copy link
Contributor Author

kovgeri01 commented Aug 23, 2024

I do not know if it's possible, but could you please add some tests that cover pipe usage as well?

you mean testing if a file() source can read a pipe?
(I added some additional tests to the pipe() source,but sadly these were added to the testdb)

@kovgeri01 kovgeri01 force-pushed the check_if_fd_checking_is_possible_before_adding_eof_checker branch 2 times, most recently from 9117af9 to c1830be Compare August 23, 2024 10:57
@kira-syslogng
Copy link
Contributor

kira-syslogng commented Aug 23, 2024

Build FAILURE

@kovgeri01 kovgeri01 force-pushed the check_if_fd_checking_is_possible_before_adding_eof_checker branch from c1830be to 2aa9c9f Compare August 23, 2024 11:22
@kovgeri01 kovgeri01 merged commit 045c879 into syslog-ng:master Aug 23, 2024
@jospezial jospezial mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HofiOne HofiOne HofiOne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New log error message: Error invoking seek on file; filename='/run/some-device-pipe', error='Illegal seek (29)'

3 participants

@kovgeri01 @HofiOne @kira-syslogng