multiline-options: Allow multi_line_timeout set to a none integer value#5002
Merged
HofiOne merged 1 commit intosyslog-ng:masterfrom Jun 21, 2024
Merged
Conversation
kovgeri01
reviewed
Jun 21, 2024
The actual implementation. and validations restrict only the value to be higher than the `follow-freq` (ideally multiplication of it). As the `follow-freq` can be much smaller than one second it makes sense to allow this value to be a non-integer value as well. Signed-off-by: Hofi <[email protected]>
HofiOne
force-pushed
the
multiline-timeout-should-accept-float
branch
from
ef11bd9 to
d9b7d24
Compare
kovgeri01
approved these changes
Jun 21, 2024
HofiOne
added a commit
to HofiOne/syslog-ng
that referenced
this pull request
Jun 24, 2024
Signed-off-by: Hofi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual implementation. and validations restrict only the value to be higher than the
follow-freq(ideally multiplication of it). As thefollow-freqcan be much smaller than one second it makes sense to allow this value to be a non-integer value as well.Signed-off-by: Hofi [email protected]