Skip to content

F/netmask6 fixes#494

Closed
deirf wants to merge 9 commits intosyslog-ng:masterfrom
deirf:f/netmask6_fixes
Closed

F/netmask6 fixes#494
deirf wants to merge 9 commits intosyslog-ng:masterfrom
deirf:f/netmask6_fixes

Conversation

@deirf
Copy link

@deirf deirf commented May 28, 2015

fixes #476
fixes #475

@ghost
Copy link

ghost commented May 29, 2015

@deirf: I have sent a pull request to your fork, please merge/reject it before any rebase.

@ihrwein
Copy link
Contributor

ihrwein commented Jun 15, 2015

@deirf : Is this PR supposed to solve #476? If that's so please add fixes #476 to the description of your PR.

This was referenced Jun 18, 2015
Closed
Open
@justcallmegreg
Copy link

justcallmegreg commented Jun 18, 2015

added.

ihrwein
ihrwein reviewed Jul 20, 2015
View reviewed changes
lib/filter/filter-expr-grammar.ym Outdated
Copy link
Contributor

@ihrwein ihrwein Jul 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the free() call in the good place? I think we should put it after filter_netmask6_new() and before the 108th line.

@deirf
Copy link
Author

deirf commented Jul 24, 2015

@lbudai could you look at this PR?
I know there is a "makefile and ifdef" review note, I will do it and send new PR about it.

@lbudai
Copy link
Collaborator

lbudai commented Jul 24, 2015

As I know, Gergo fixed the makefile related issues, so talk to him and when you think, you are finished (and don't have any unprocessed review note), just ping me.

I have lots of todos, and I've a priority list on patches.
Bazsi sent some PRs and I want to start with those PRs.

@justcallmegreg
Copy link

justcallmegreg commented Jul 24, 2015

You can check my solution here.
Mind that it's not the final structure.

justcallmegreg
justcallmegreg reviewed Jul 24, 2015
View reviewed changes
lib/filter/filter-netmask6.c Outdated
Copy link

@justcallmegreg justcallmegreg Jul 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'get_normalized_address'

@deirf
Copy link
Author

deirf commented Jul 31, 2015

@ gregory094 I saw you solution please check my modifications and my answers your proposals.

ihrwein
ihrwein reviewed Aug 10, 2015
View reviewed changes
lib/filter/filter-expr-grammar.ym
Copy link
Contributor

@ihrwein ihrwein Aug 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when syslog-ng is configured without IPv6 support but the user tries to use this filter?

Copy link
Author

@deirf deirf Aug 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error parsing filter expression, filter plugin netmask6 not found OR you may not used double quotes in your filter expression in....

Fried Zoltan added 8 commits September 7, 2015 14:59
test_log_message: remove an unused variable
e524eda 
Signed-off-by: Fried Zoltan <[email protected]>
test_filters: Refactoring test netmask6 filter
21d8e57 
Signed-off-by: Fried Zoltan <[email protected]>
netmask6: Fix masking both part of ipv6 address on big_endian systems
da36a4e 
Signed-off-by: Fried Zoltan <[email protected]>
netmask6: rename get_network_address to filter_netmask6_calc_network_…
89f3792 
…address

Signed-off-by: Fried Zoltan <[email protected]>
netmask6: swap 'lo' in 'hi' variable for better intelligibility
6489241 
Signed-off-by: Fried Zoltan <[email protected]>
netmask6: rename _in6_addr_compare to _in6_addr_equals
807bdfe 
Signed-off-by: Fried Zoltan <[email protected]>
netmask6: Validate input values and stop running if netmask6 filter p…
d554dbb 
…arameter is wrong.

Signed-off-by: Fried Zoltan <[email protected]>
netmask6: Add useful error messages
882ab9e 
Signed-off-by: Fried Zoltan <[email protected]>
lib: using netmask filter 6 code if it is enabled
76744eb 
Signed-off-by: Gregory Nagy <[email protected]>
Signed-off-by: Fried Zoltan <[email protected]>
@kira-syslogng
Copy link
Contributor

kira-syslogng commented Feb 9, 2017

Can one of the admins verify this patch?

@presidento presidento closed this Mar 1, 2017
HofiOne pushed a commit to HofiOne/syslog-ng that referenced this pull request Apr 4, 2025
@MrAnno @HofiOne
news: add feature syslog-ng#494
d5b9b45 
Signed-off-by: László Várady <[email protected]>
HofiOne pushed a commit to HofiOne/syslog-ng that referenced this pull request Apr 9, 2025
@MrAnno @HofiOne
news: add feature syslog-ng#494
234510a 
Signed-off-by: László Várady <[email protected]>
Signed-off-by: Hofi <[email protected]>
HofiOne pushed a commit to HofiOne/syslog-ng that referenced this pull request Apr 17, 2025
@MrAnno @HofiOne
news: add feature syslog-ng#494
ed1a460 
Signed-off-by: László Várady <[email protected]>
HofiOne pushed a commit to HofiOne/syslog-ng that referenced this pull request Apr 17, 2025
@MrAnno @HofiOne
news: add feature syslog-ng#494
1206a88 
Signed-off-by: László Várady <[email protected]>
HofiOne pushed a commit to HofiOne/syslog-ng that referenced this pull request Apr 17, 2025
@MrAnno @HofiOne
news: add feature syslog-ng#494
1104cd5 
Signed-off-by: László Várady <[email protected]>
HofiOne pushed a commit to HofiOne/syslog-ng that referenced this pull request Apr 23, 2025
@MrAnno @HofiOne
news: add feature syslog-ng#494
a3eb8cf 
Signed-off-by: László Várady <[email protected]>
Signed-off-by: Hofi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lbudai lbudai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a warning message to netmask6 filter driver when filter is invalid. Fix netmask6 filter on bigendian systems

6 participants

@deirf @ihrwein @justcallmegreg @lbudai @kira-syslogng @presidento