Skip to content

macros: guard ipv6 code with SYSLOG_NG_ENABLE_IPV6#4880

Merged
alltilla merged 1 commit intosyslog-ng:masterfrom
petermarko:fix/ipv6-disable
Apr 5, 2024
Merged

macros: guard ipv6 code with SYSLOG_NG_ENABLE_IPV6#4880
alltilla merged 1 commit intosyslog-ng:masterfrom
petermarko:fix/ipv6-disable

Conversation

@petermarko
Copy link
Contributor

With ipv6 disabled, there are linking errors currently. This fixes it by not using the symbols when IPv6 is disabled.

Solves #4810 with my config options

https://github.com/openembedded/meta-openembedded/blob/2487e65ee3842b6ae0c7a2628985be6189ed9ebf/meta-oe/recipes-support/syslog-ng/syslog-ng_4.6.0.bb

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

1 similar comment
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@MrAnno
Copy link
Collaborator

MrAnno commented Apr 4, 2024

@kira-syslogng ok to test

@alltilla
Copy link
Collaborator

alltilla commented Apr 5, 2024

Thank you!

@alltilla alltilla merged commit 9c3d217 into syslog-ng:master Apr 5, 2024
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Apr 5, 2024
@czanik
Copy link
Collaborator

czanik commented Apr 5, 2024

@petermarko BTW: what is the use case behind disabling IPv6 support in syslog-ng? It does not pull in any additional dependencies.

@petermarko
Copy link
Contributor Author

@czanik there is no special syslog-ng related usecase behind it.

We use yocto/openembedded (as I linked in the description) and since we don't enable ipv6 in one of our distros (for multiple other reasons), yocto automatically passes --disable-ipv6 option and the build failed.

halstead pushed a commit to openembedded/meta-openembedded that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants